[webkit-changes] [WebKit/WebKit] c2f909: Nullptr crash due to `display:block ruby` and cont...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2f9092d3a8e7bf63dd1c55c9917cd391fff2665
      https://github.com/WebKit/WebKit/commit/c2f9092d3a8e7bf63dd1c55c9917cd391fff2665
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    A LayoutTests/fast/ruby/ruby-block-continuation-crash-expected.txt
    A LayoutTests/fast/ruby/ruby-block-continuation-crash.html
    M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp

  Log Message:
  -----------
  Nullptr crash due to `display:block ruby` and continuations
https://bugs.webkit.org/show_bug.cgi?id=268770
rdar://121960530

Reviewed by Alan Baradlay.

Continuations may end up splitting anonymous 'display:ruby' box inside block ruby.

* LayoutTests/fast/ruby/ruby-block-continuation-crash-expected.txt: Added.
* LayoutTests/fast/ruby/ruby-block-continuation-crash.html: Added.
* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild):

Find the correct anonymous box from nested continuation structure.

Canonical link: https://commits.webkit.org/279005@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications