[webkit-changes] [WebKit/WebKit] d48be5: [Unified Text Replacement] Refactor `m_textIndicat...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d48be59b226a3da86b16e3948e08db42c6637263
      https://github.com/WebKit/WebKit/commit/d48be59b226a3da86b16e3948e08db42c6637263
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-05-19 (Sun, 19 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm
    M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h

  Log Message:
  -----------
  [Unified Text Replacement] Refactor `m_textIndicatorCharacterRanges` to be a HashMap
https://bugs.webkit.org/show_bug.cgi?id=274357
rdar://128336962

Reviewed by Abrar Rahman Protyasha.

Work towards improved type safety and consistency by refactoring `m_textIndicatorCharacterRanges`
to be a HashMap, like the other state instance variables.

* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveReplacements):
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidUpdateStateForReplacement):
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession<WebUnifiedTextReplacementSessionData::ReplacementType::PlainText>):
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange):
(WebKit::UnifiedTextReplacementController::textReplacementSessionPerformEditActionForPlainText):
(WebKit::UnifiedTextReplacementController::textReplacementSessionPerformEditActionForRichText):
(WebKit::UnifiedTextReplacementController::removeTransparentMarkersForUUID):
(WebKit::UnifiedTextReplacementController::removeTransparentMarkersForSession):
(WebKit::UnifiedTextReplacementController::contextRangeForSessionOrRangeWithUUID const):
(WebKit::UnifiedTextReplacementController::createTextIndicator):
(WebKit::UnifiedTextReplacementController::replaceContentsOfRangeInSessionInternal):
(WebKit::UnifiedTextReplacementController::replaceContentsOfRangeInSession):
* Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h:

Canonical link: https://commits.webkit.org/278978@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications