[webkit-changes] [WebKit/WebKit] 2713a2: Clean up some platform-specific feature flags

Wenson Hsieh noreply at github.com
Sun May 19 17:24:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2713a25b31f311b045b19c0b026fb052fb99b79e
      https://github.com/WebKit/WebKit/commit/2713a25b31f311b045b19c0b026fb052fb99b79e
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-05-19 (Sun, 19 May 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm

  Log Message:
  -----------
  Clean up some platform-specific feature flags
https://bugs.webkit.org/show_bug.cgi?id=274369
rdar://128278820

Reviewed by Abrar Rahman Protyasha and Richard Robinson.

Turn `HAVE_UI_WK_DOCUMENT_CONTEXT` on when compiling for tvOS. Also, move the implementation of
`-requestDocumentContext:completionHandler:` (guarded by `HAVE(UI_WK_DOCUMENT_CONTEXT)`) and the
code behind `USE(UICONTEXTMENU)` out of the `ENABLE(DRAG_SUPPORT)` compile-time guards in
`WKContentViewInteraction.mm`.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView insertTextPlaceholderWithSize:completionHandler:]):
(-[WKContentView removeTextPlaceholder:willInsertText:completionHandler:]):
(sizesOfPlaceholderElementsToInsertWhenDroppingItems):
(-[WKContentView _handleDropByInsertingImagePlaceholders:session:]):
(-[WKContentView _dragInteraction:shouldDelayCompetingGestureRecognizer:]):
(-[WKContentView _dragInteraction:dataOwnerForSession:]):
(-[WKContentView _dragInteraction:itemsForAddingToSession:withTouchAtPoint:completion:]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView dragInteraction:itemsForBeginningSession:]):
(-[WKContentView dragInteraction:previewForLiftingItem:session:]):
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView dragInteraction:sessionWillBegin:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dragInteraction:previewForCancellingItem:withDefault:]):
(-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):
(-[WKContentView dragInteraction:sessionDidTransferItems:]):
(-[WKContentView dragInteraction:prepareDragSession:completion:]):
(-[WKContentView dragInteraction:itemsForAddingToSession:forTouchAtPoint:completion:]):
(-[WKContentView _dropInteraction:dataOwnerForSession:]):
(-[WKContentView dropInteraction:canHandleSession:]):
(-[WKContentView dropInteraction:sessionDidEnter:]):
(-[WKContentView dropInteraction:sessionDidUpdate:]):
(-[WKContentView dropInteraction:sessionDidExit:]):
(-[WKContentView dropInteraction:performDrop:]):
(-[WKContentView dropInteraction:item:willAnimateDropWithAnimator:]):
(-[WKContentView dropInteraction:concludeDrop:]):
(-[WKContentView dropInteraction:previewForDroppingItem:withDefault:]):
(-[WKContentView dropInteraction:sessionDidEnd:]):
(-[WKContentView cancelActiveTextInteractionGestures]):
(-[WKContentView textEffectsWindow]):
(-[WKContentView _autofillContext]):
(uiImageForImage):
(createTargetedPreview):
(createFallbackTargetedPreview):
(-[WKContentView _createTargetedContextMenuHintPreviewForFocusedElement:]):
(-[WKContentView positionInformationHasImageOverlayDataDetector]):
(-[WKContentView _createTargetedContextMenuHintPreviewIfPossible]):
(-[WKContentView _removeContextMenuHintContainerIfPossible]):
(toWebDocumentRequestOptions):
(toWebRequest):
(-[WKContentView adjustSelectionWithDelta:completionHandler:]):
(-[WKContentView requestDocumentContext:completionHandler:]):
(-[WKContentView selectPositionAtPoint:withContextRequest:completionHandler:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:

Canonical link: https://commits.webkit.org/278973@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list