[webkit-changes] [WebKit/WebKit] dbcbbe: Add invoke defaults for dialogs

Keith Cirkel noreply at github.com
Sun May 19 03:51:45 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dbcbbe87dd98b259cf8815a53c9bc7276892de6f
      https://github.com/WebKit/WebKit/commit/dbcbbe87dd98b259cf8815a53c9bc7276892de6f
  Author: Keith Cirkel <webkit at keithcirkel.co.uk>
  Date:   2024-05-19 (Sun, 19 May 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-dialog-behavior.tentative-expected.txt
    A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-dialog-behavior.tentative-expected.txt
    M Source/WebCore/dom/Element.h
    M Source/WebCore/html/HTMLDialogElement.cpp
    M Source/WebCore/html/HTMLDialogElement.h
    M Source/WebCore/html/HTMLElement.h
    M Source/WebCore/html/HTMLFormControlElement.cpp

  Log Message:
  -----------
  Add invoke defaults for dialogs
https://bugs.webkit.org/show_bug.cgi?id=270602

Reviewed by Anne van Kesteren.

This adds the `handleInvokeInternal` logic for HTMLDialogElement showmodal/close
a dialog.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-dialog-behavior.tentative-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-dialog-behavior.tentative-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-dialog-behavior.tentative-expected.txt.
* Source/WebCore/dom/Element.h:
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::isValidInvokeAction):
(WebCore::HTMLDialogElement::handleInvokeInternal):
* Source/WebCore/html/HTMLDialogElement.h:
* Source/WebCore/html/HTMLElement.h:
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::invokeAction const):

Canonical link: https://commits.webkit.org/278970@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list