[webkit-changes] [WebKit/WebKit] 26b41e: Cleanup various "nil vs empty" confusions in seria...

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26b41e6069aaf52423f7f73664cf8c29aef70bd8
      https://github.com/WebKit/WebKit/commit/26b41e6069aaf52423f7f73664cf8c29aef70bd8
  Author: Brady Eidson <beidson at apple.com>
  Date:   2024-05-18 (Sat, 18 May 2024)

  Changed paths:
    M Source/WebKit/Shared/Cocoa/CoreIPCPassKit.h
    M Source/WebKit/Shared/Cocoa/CoreIPCPassKit.mm
    M Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in
    M Source/WebKit/Shared/Cocoa/CoreIPCPersonNameComponents.mm
    M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm

  Log Message:
  -----------
  Cleanup various "nil vs empty" confusions in serializaiton of some ObjC types
rdar://128027011
https://bugs.webkit.org/show_bug.cgi?id=274342

Reviewed by Alex Christensen.

Similar to what I fixed over in https://commits.webkit.org/277627@main, various other ObjC serializers
have some "nil vs empty" confusion that can lead to various wonky side effects.

Let's support the different between nil and empty wherever we can spot it.

* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.h:
(WebKit::CoreIPCPKContact::CoreIPCPKContact):
* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.mm:
(WebKit::CoreIPCPKContact::CoreIPCPKContact):
(WebKit::CoreIPCPKContact::toID const):
* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in:

* Source/WebKit/Shared/Cocoa/CoreIPCPersonNameComponents.mm:
(WebKit::CoreIPCPersonNameComponents::toID const):

* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(TEST(IPCSerialization, Basic)):

Canonical link: https://commits.webkit.org/278966@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications