[webkit-changes] [WebKit/WebKit] 1b08c7: MediaFragmentURIParser rejects valid NPT strings i...

Commit Queue noreply at github.com
Sat May 18 02:46:55 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b08c7ea9a82ee1ae8de6f2df1199abca0a2ded1
      https://github.com/WebKit/WebKit/commit/1b08c7ea9a82ee1ae8de6f2df1199abca0a2ded1
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-05-18 (Sat, 18 May 2024)

  Changed paths:
    A LayoutTests/media/media-fragments/TC0095-expected.txt
    A LayoutTests/media/media-fragments/TC0095.html
    M LayoutTests/media/media-fragments/media-fragments.js
    M Source/WebCore/html/MediaFragmentURIParser.cpp

  Log Message:
  -----------
  MediaFragmentURIParser rejects valid NPT strings if 'hours' is defined using 1 digit

https://bugs.webkit.org/show_bug.cgi?id=160199

Reviewed by Eric Carlson.

This patch aligns WebKit with Blink / Chromium and web specification [1]:

Merge: https://chromium.googlesource.com/chromium/src/+/139d93b86c305ec60e9f41890cefcb4972dd8e7f

[1] https://www.w3.org/TR/media-frags/#naming-time

"Minutes and seconds must be specified as exactly two digits, hours and fractional seconds can be any number of digits."

As above, and also per RFC2326 [2], 'hours' can be single digit.

[2] https://www.ietf.org/rfc/rfc2326.txt

Refer:

> npt-hh       =   1*DIGIT     ; any positive number

* Source/WebCore/html/MediaFragmentURIParser.cpp:
(MediaFragmentURIParser::parseNPTTime):
* LayoutTests/media/media-fragments/TC0095.html: Add Test Case
* LayoutTests/media/media-fragments/TC0095-expected.txt: Add Test Case Expectation
* LayoutTests/media/media-fragments/media-fragments.js: Update Test script

Canonical link: https://commits.webkit.org/278951@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list