[webkit-changes] [WebKit/WebKit] c934cb: Remove notify option NOTIFY_OPT_LOOPBACK in WebKit

Per Arne Vollan noreply at github.com
Fri May 17 19:28:32 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c934cb5ebbd2faa02acd746740672038d7922bd3
      https://github.com/WebKit/WebKit/commit/c934cb5ebbd2faa02acd746740672038d7922bd3
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M Source/WebKit/Shared/AuxiliaryProcess.h
    M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm
    M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
    M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm

  Log Message:
  -----------
  Remove notify option NOTIFY_OPT_LOOPBACK in WebKit
https://bugs.webkit.org/show_bug.cgi?id=272977
rdar://128307652

Reviewed by Sihui Liu.

Remove notify option NOTIFY_OPT_LOOPBACK in WebKit, since this feature is now enabled with an
entitlement. This patch effectively reverts <https://commits.webkit.org/275186@main>. The
NOTIFY_OPT_DISPATCH applies regardless of whether NOTIFY_BLOCKING is enabled.

This was initially landed in <https://commits.webkit.org/278639@main>, but then reverted in
<https://commits.webkit.org/278656@main>, because it introduced a crash on startup on older
OS builds.

* Source/WebKit/Shared/AuxiliaryProcess.h:
* Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::setNotifyOptions):
* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
(WebKit::XPCServiceMain):
(WebKit::shouldRestrictNotifyd): Deleted.
(WebKit::setNotifyOptions): Deleted.
* Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::applySandbox):

Canonical link: https://commits.webkit.org/278942@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list