[webkit-changes] [WebKit/WebKit] 5dc8c9: PDFs should be downloaded in lockdown mode

Commit Queue noreply at github.com
Fri May 17 11:38:07 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5dc8c9e2659149429af495713cb8cf8a62ef4dce
      https://github.com/WebKit/WebKit/commit/5dc8c9e2659149429af495713cb8cf8a62ef4dce
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm

  Log Message:
  -----------
  PDFs should be downloaded in lockdown mode
https://bugs.webkit.org/show_bug.cgi?id=271003
rdar://124636755

Reviewed by Chris Dumez.

This functionality was first introduced in https://bugs.webkit.org/show_bug.cgi?id=237245, but
was disabled for macOS in https://bugs.webkit.org/show_bug.cgi?id=241741. This patch is to re-enable it.

This functionality should be covered by WKDownload.LockdownModePDF. Which is also fixed in this change
such that it fails whenever the conditional doesn't exist.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForResponseShared):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

Originally-landed-as: 272448.740 at safari-7618-branch (c369f5018e91). rdar://128088854
Canonical link: https://commits.webkit.org/278919@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list