[webkit-changes] [WebKit/WebKit] f2967e: [UIProcess] Unsafe downcast in ScrollingTreeSticky...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2967e8171d183ade5bbe655c15924af50e1af8f
      https://github.com/WebKit/WebKit/commit/f2967e8171d183ade5bbe655c15924af50e1af8f
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
    M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp
    M Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp
    M Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollProxyNode.cpp
    M Source/WebCore/page/scrolling/ScrollingTreeStickyNode.cpp

  Log Message:
  -----------
  [UIProcess] Unsafe downcast in ScrollingTreeStickyNode::computeLayerPosition leading to type confusion.
https://bugs.webkit.org/show_bug.cgi?id=271395
rdar://125084284

Reviewed by Chris Dumez.

Fix various places in scrolling tree-related code where we do unchecked `downcast<>`s of
scrolling tree types.

* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewVisualViewportChanged):
(WebCore::AsyncScrollingCoordinator::setViewportConstraintedNodeConstraints):
* Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp:
(WebCore::ScrollingStateOverflowScrollProxyNode::dumpProperties const):
* Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::computeLayerPosition const):
* Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollProxyNode.cpp:
(WebCore::ScrollingTreeOverflowScrollProxyNode::dumpProperties const):
* Source/WebCore/page/scrolling/ScrollingTreeStickyNode.cpp:
(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):

Originally-landed-as: 272448.773 at safari-7618-branch (052845bc6c5c). rdar://128088754
Canonical link: https://commits.webkit.org/278914@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications