[webkit-changes] [WebKit/WebKit] 0555bb: Transparent markers are failing to be set for subr...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0555bbdd2437009fcc47bd981794c5eea60fbf93
      https://github.com/WebKit/WebKit/commit/0555bbdd2437009fcc47bd981794c5eea60fbf93
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h

  Log Message:
  -----------
  Transparent markers are failing to be set for subranges.
https://bugs.webkit.org/show_bug.cgi?id=274282
rdar://128230394

Reviewed by Aditya Keerthi.

When traversing subranges we were using the sub UUID to look for the
parent range, which obviously does not work. Also took the opportunity
to try and consolidate some of the code, but it could probably still
use more work, so I am leaving the FIXME.

* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::removeTransparentMarkersForUUID):
(WebKit::UnifiedTextReplacementController::removeTransparentMarkersForSession):
(WebKit::UnifiedTextReplacementController::contextRangeForSessionOrRangeWithUUID const):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::updateTextIndicatorStyleVisibilityForID):
* Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h:

Canonical link: https://commits.webkit.org/278903@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications