[webkit-changes] [WebKit/WebKit] 4f5aa1: [WPE][GTK] createNewPage in WebKitUIClient.cpp nee...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f5aa1a1182dc07afb17a676cf68ee07e5843179
      https://github.com/WebKit/WebKit/commit/4f5aa1a1182dc07afb17a676cf68ee07e5843179
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h

  Log Message:
  -----------
  [WPE][GTK] createNewPage in WebKitUIClient.cpp needs some hooking up of the API::PageConfiguration
https://bugs.webkit.org/show_bug.cgi?id=273975

Reviewed by Darin Adler and Alex Christensen.

This resolves a FIXME where the API::PageConfiguration gets ignored when
creating a new related web view. The control flow isn't obvious unless
you're familiar with GTK/WPE ports, but the WebKitWebView emits the
WebKitWebView::create signal, then the application using WebKit is
supposed to create a new web view using
webkit_web_view_new_with_related_view().

Note that some members of the PageConfiguration are always taken from
the related view rather than the PageConfiguration we receive.

This commit additionally adjusts the sanity check in
webkitWebViewCreateNewPage to match the corresponding Cocoa checks in
UIDelegate::UIClient::createNewPage, so it (hopefully) won't fail when
site isolation is enabled. This was suggested by Carlos Garcia.

* Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewConstructed):
(webkitWebViewCreateNewPage):
* Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h:

Canonical link: https://commits.webkit.org/278896@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications