[webkit-changes] [WebKit/WebKit] d3ad1d: WebGL fails to compile shaders with out variables ...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d3ad1d842868cafb05b7fca1a058fa83d00855d2
      https://github.com/WebKit/WebKit/commit/d3ad1d842868cafb05b7fca1a058fa83d00855d2
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    M Source/ThirdParty/ANGLE/src/tests/gl_tests/GLSLTest.cpp

  Log Message:
  -----------
  WebGL fails to compile shaders with out variables that are arrays and start with underscore
rdar://126944294

Reviewed by Chris Dumez.

Integrates upstream commit:
commit e0e91b8cbb2e096d2d009cd0d1fbe20d785f2263
Author: Kimmo Kinnunen <kkinnunen at apple.com>
Date:   Mon Apr 22 18:11:30 2024 -0700
Metal: Fix rewritten out variables with underscores

Fix compilation in case of output variables start with underscores.
Make name emission always emit MSL name ANGLE_{name}, so that GLSL `_e`
and `e` cannot clash. This regressed in angleproject:8558.

Bug: b/335744344
Change-Id: Ibae4dba4a24888acc1461582e69d48218ba11176

Originally-landed-as: bce91c8033e3. rdar://128091308
Canonical link: https://commits.webkit.org/278880@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications