[webkit-changes] [WebKit/WebKit] 47944f: [WGSL] Add type checking for compound assignment

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47944ff1d4a0313a1e1581a58e11b1a3a067735c
      https://github.com/WebKit/WebKit/commit/47944ff1d4a0313a1e1581a58e11b1a3a067735c
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    A Source/WebGPU/WGSL/tests/invalid/compound-assignment.wgsl
    M Source/WebGPU/WGSL/tests/valid/fuzz-127229681.wgsl
    M Source/WebGPU/WGSL/tests/valid/pack-unpack.wgsl

  Log Message:
  -----------
  [WGSL] Add type checking for compound assignment
https://bugs.webkit.org/show_bug.cgi?id=274212
rdar://128064852

Reviewed by Mike Wyrzykowski.

Resolve a long standing fixme and add type checking for the compound assignments
by sharing the code with binary expressions.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::binaryExpression):
(WGSL::TypeChecker::chooseOverload):
* Source/WebGPU/WGSL/tests/invalid/compound-assignment.wgsl: Added.
* Source/WebGPU/WGSL/tests/valid/fuzz-127229681.wgsl:
* Source/WebGPU/WGSL/tests/valid/pack-unpack.wgsl:

Canonical link: https://commits.webkit.org/278848@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications