[webkit-changes] [WebKit/WebKit] 8001ac: [WebGPU] Curl noise is showing more dark / shadows...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8001ac70372ae2f3dea9e56c877a07c4c6b5dbd1
      https://github.com/WebKit/WebKit/commit/8001ac70372ae2f3dea9e56c877a07c4c6b5dbd1
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm
    M Source/WebGPU/WebGPU/WebGPU.h

  Log Message:
  -----------
  [WebGPU] Curl noise is showing more dark / shadows in Safari / WebKit compared to Chrome Canary
https://bugs.webkit.org/show_bug.cgi?id=274174
<rdar://problem/128060711>

Reviewed by Dan Glastonbury.

Auto-generated layouts had a bug where it was assumed a given resource
had the same offset in the Metal argument buffer across vertex, fragment,
and compute stages.

This is not necessarily the case, we need to store seperate indices for
each stage.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::DeviceImpl::createBindGroupLayout):
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::addPipelineLayouts):
* Source/WebGPU/WebGPU/WebGPU.h:

Canonical link: https://commits.webkit.org/278846@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications