[webkit-changes] [WebKit/WebKit] 188341: REGRESSION (278793 at main): Text invisible after a U...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 188341d5081989a170faf4b6e1b93ad87a02ed73
      https://github.com/WebKit/WebKit/commit/188341d5081989a170faf4b6e1b93ad87a02ed73
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm

  Log Message:
  -----------
  REGRESSION (278793 at main): Text invisible after a UnifiedTextReplacement session ends
https://bugs.webkit.org/show_bug.cgi?id=274235
rdar://128166540

Reviewed by Wenson Hsieh and Abrar Rahman Protyasha.

278793 at main refactored the logic to restore text visibility. However, by moving
the logic to end of `UnifiedTextReplacementController::didEndTextReplacementSession`,
all other state was already cleared, making `removeTransparentMarkersForSession`
a no-op.

Fix by removing the transparency markers first.

* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):

Canonical link: https://commits.webkit.org/278843@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications