[webkit-changes] [WebKit/WebKit] fb01f8: [MSE] If src attribute is defined, ignore source a...

Jean-Yves Avenard noreply at github.com
Wed May 15 16:31:59 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb01f8840fd2c2484f67dcc54ab9d5be35946fb5
      https://github.com/WebKit/WebKit/commit/fb01f8840fd2c2484f67dcc54ab9d5be35946fb5
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
    M LayoutTests/media/media-source/media-managedmse-airplay-expected.txt
    A LayoutTests/media/media-source/media-managedmse-airplay-withsrc-expected.txt
    A LayoutTests/media/media-source/media-managedmse-airplay-withsrc.html
    M LayoutTests/media/media-source/media-managedmse-airplay.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  [MSE] If src attribute is defined, ignore source alternative
https://bugs.webkit.org/show_bug.cgi?id=274195
rdar://128098363

Reviewed by Youenn Fablet and Eric Carlson.

Per spec, if a media element has a src attribute defined, `<source>` alternative are ignored.
As such we should ignore the presence of the source children if a src attribute is set to determine
if the ManagedMediaSource is in open state.

* LayoutTests/media/media-source/media-managedmse-airplay-expected.txt:
* LayoutTests/media/media-source/media-managedmse-airplay-withsrc-expected.txt: Added.
* LayoutTests/media/media-source/media-managedmse-airplay-withsrc.html: Copied from LayoutTests/media/media-source/media-managedmse-airplay.html.
* LayoutTests/media/media-source/media-managedmse-airplay.html:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasWirelessPlaybackTargetAlternative const):

Canonical link: https://commits.webkit.org/278834@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list