[webkit-changes] [WebKit/WebKit] 6d6ab5: [Unified Text Replacement] Undo-ing a text replace...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d6ab5c69589ac911dda794996eb3681aa571eba
      https://github.com/WebKit/WebKit/commit/6d6ab5c69589ac911dda794996eb3681aa571eba
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm

  Log Message:
  -----------
  [Unified Text Replacement] Undo-ing a text replacement session sometimes does not undo properly
https://bugs.webkit.org/show_bug.cgi?id=274230
rdar://128075689

Reviewed by Abrar Rahman Protyasha.

Fix by using the marker before it gets removed, instead of afterwards.

* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession<WebUnifiedTextReplacementType::PlainText>):
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange):

Canonical link: https://commits.webkit.org/278826@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications