[webkit-changes] [WebKit/WebKit] 9088dd: [visionOS] Remove WK_PLATFORM_NAME fallback logic

Elliott Williams noreply at github.com
Wed May 15 10:35:16 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9088dd28c8893062defa259d9a205aa90ea7b807
      https://github.com/WebKit/WebKit/commit/9088dd28c8893062defa259d9a205aa90ea7b807
  Author: Elliott Williams <emw at apple.com>
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
    M Configurations/SDKVariant.xcconfig
    M PerformanceTests/DecoderTest/Configurations/Base.xcconfig
    M PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig
    M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
    M Source/JavaScriptCore/Configurations/libJavaScriptCore.xcconfig
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/JavaScriptCore/Scripts/process-entitlements.sh
    M Source/WebKit/Configurations/BaseTarget.xcconfig
    M Source/WebKit/Configurations/BaseXPCService.xcconfig
    M Source/WebKit/Configurations/WebKit.xcconfig
    M Source/WebKit/Configurations/WebKitSwift.xcconfig
    M Source/WebKit/Configurations/adattributiond.xcconfig
    M Source/WebKit/Scripts/postprocess-header-rule
    M Source/WebKit/Scripts/process-entitlements.sh
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/scripts/check-xcfilelists.sh
    M Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
    M Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py
    M Tools/TestWebKitAPI/Scripts/check-xcfilelists.sh
    M Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh

  Log Message:
  -----------
  [visionOS] Remove WK_PLATFORM_NAME fallback logic
rdar://127518376
https://bugs.webkit.org/show_bug.cgi?id=273717

Reviewed by Tim Horton.

The internal visionOS SDK declares a FALLBACK_PLATFORM_NAME of
iphoneos/iphonesimulator. Start ignoring this, so that internal visionOS
builds match public SDK builds.

Comb through xcconfigs and build scripts and make sure that
WK_PLATFORM_NAME logic which recognized iphoneos/iphonesimulator handles
xros/xrsimulator.

* Configurations/SDKVariant.xcconfig:
* PerformanceTests/DecoderTest/Configurations/Base.xcconfig:
* PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:
* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
* Source/JavaScriptCore/Configurations/libJavaScriptCore.xcconfig:
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Scripts/postprocess-header-rule:
* Source/JavaScriptCore/Scripts/process-entitlements.sh:
* Source/WebKit/Configurations/BaseTarget.xcconfig:
* Source/WebKit/Configurations/BaseXPCService.xcconfig:
* Source/WebKit/Configurations/WebKit.xcconfig: Replace an intentional
  use of PLATFORM_NAME with WK_PLATFORM_NAME, now that it's possible to
  disambiguate between visionOS and iOS.
* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Source/WebKit/Configurations/adattributiond.xcconfig:
* Source/WebKit/Scripts/postprocess-header-rule:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

In generate_xcfilelists_lib scripts, use WK_PLATFORM_NAME and declare
support for xros/xrsimulator platforms.

* Source/WebKitLegacy/scripts/check-xcfilelists.sh:
* Tools/DumpRenderTree/Scripts/check-xcfilelists.sh:
* Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
(JavaScriptCoreGenerator):
(WebCoreGenerator):
(WebKitGenerator):
(WebKitLegacyGenerator):
(TestWebKitAPIGenerator):
* Tools/TestWebKitAPI/Scripts/check-xcfilelists.sh:
* Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh:

Canonical link: https://commits.webkit.org/278812@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list