[webkit-changes] [WebKit/WebKit] 8a064b: REGRESSION (278793 at main): Text remains invisible a...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a064b27ec04249b43582b34e139c14c561b94ca
      https://github.com/WebKit/WebKit/commit/8a064b27ec04249b43582b34e139c14c561b94ca
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm

  Log Message:
  -----------
  REGRESSION (278793 at main): Text remains invisible after calling `-[WKWebView _disableTextIndicatorStylingWithUUID:]`
https://bugs.webkit.org/show_bug.cgi?id=274199
rdar://128109686

Reviewed by Megan Gardner, Tim Horton and Richard Robinson.

Following 278793 at main, `TransparentContent` markers are only removed for ranges
tracked by `UnifiedTextReplacementController`. This is incorrect, as these
markers are also added for ranges created by the `WKWebView` SPI to add text
indicator styles. Consequently, when attempting to remove markers via
`-[WKWebView _disableTextIndicatorStylingWithUUID:]`, nothing happens, leaving
text in an invisible state.

Fix by adding a separate removal path for text indicator styles created using
`WKWebView` SPI.

* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::updateTextIndicatorStyleVisibilityForID):

Canonical link: https://commits.webkit.org/278800@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications