[webkit-changes] [WebKit/WebKit] 5384ee: [iOS] -_dragInteraction:prepareForSession:completi...

Wenson Hsieh noreply at github.com
Tue May 14 22:05:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5384ee4f03d2e4233dba92579d53cf168bd97bba
      https://github.com/WebKit/WebKit/commit/5384ee4f03d2e4233dba92579d53cf168bd97bba
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-05-14 (Tue, 14 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [iOS] -_dragInteraction:prepareForSession:completion: doesn't call the completion block when selecting live text
https://bugs.webkit.org/show_bug.cgi?id=274183

Reviewed by Abrar Protyasha.

Make sure that this completion block is invoked when long pressing on Live Text in an image; this
doesn't cause issues in practice since `UIDragInteraction` / `BEDragInteraction` internally invokes
the underlying completion handler anyways after a short timeout (500 ms), but it's still not great
that we leave the callback dangling for that long.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _dragInteraction:prepareForSession:completion:]):

Canonical link: https://commits.webkit.org/278796@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list