[webkit-changes] [WebKit/WebKit] f27603: [WebGPU] Buffer sizes for pipelines need to be dec...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f27603377e0a3151445d1d0f986f5f3dee6b05a9
      https://github.com/WebKit/WebKit/commit/f27603377e0a3151445d1d0f986f5f3dee6b05a9
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-14 (Tue, 14 May 2024)

  Changed paths:
    M LayoutTests/fast/webgpu/fuzz-126848520-explicit-layout-expected.txt
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/ComputePipeline.h
    M Source/WebGPU/WebGPU/ComputePipeline.mm
    M Source/WebGPU/WebGPU/Pipeline.h
    M Source/WebGPU/WebGPU/Pipeline.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPipeline.h
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] Buffer sizes for pipelines need to be decoupled from the underlying layouts (274098)
https://bugs.webkit.org/show_bug.cgi?id=274098
<radar://128011723>

Reviewed by Tadeu Zagallo.

The same bind group layout can be used in multiple pipelines,
so we should store the information for buffer sizes in the pipeline
and not the layout itself.

* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::executePreDispatchCommands):
* Source/WebGPU/WebGPU/ComputePipeline.h:
(WebGPU::ComputePipeline::create):
* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::ComputePipeline::ComputePipeline):
(WebGPU::ComputePipeline::bufferSizes const):
* Source/WebGPU/WebGPU/Pipeline.h:
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createLibrary):
(WebGPU::errorValidatingBindGroup):
(WebGPU::validateBindGroup): Deleted.
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPipeline.h:
(WebGPU::RenderPipeline::create):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::RenderPipeline):
(WebGPU::m_bufferSizes):
(WebGPU::RenderPipeline::bufferSizes const):

Canonical link: https://commits.webkit.org/278794@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications