[webkit-changes] [WebKit/WebKit] fe2235: Disable default media controls scrubber on Netflix...

Dana Estra noreply at github.com
Tue May 14 16:28:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe2235a226b0e072a75314cfd677af5b261164d1
      https://github.com/WebKit/WebKit/commit/fe2235a226b0e072a75314cfd677af5b261164d1
  Author: Dana Estra <destra at apple.com>
  Date:   2024-05-14 (Tue, 14 May 2024)

  Changed paths:
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js

  Log Message:
  -----------
  Disable default media controls scrubber on Netflix.com on macOS
https://bugs.webkit.org/show_bug.cgi?id=274128
rdar://126645029

Reviewed by Jer Noble.

When the default media controls are showing on Netflix.com on macOS
(notably in in-window mode), Netflix interferes with scrubbing
And breaks video playback. To fix this, we should disable scrubbing
When the default media controls are showing and we are in fullscreen.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::supportsSeeking const):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype._updateControlsIfNeeded):

Canonical link: https://commits.webkit.org/278784@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list