[webkit-changes] [WebKit/WebKit] a38c02: Cherry-pick e3ec0669b549. rdar://problem/113156967

Tim Horton noreply at github.com
Tue May 14 16:13:26 PDT 2024


  Branch: refs/heads/safari-7617.1.3-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: a38c02a57e8970c368df8e48a0d9fd37d46537f2
      https://github.com/WebKit/WebKit/commit/a38c02a57e8970c368df8e48a0d9fd37d46537f2
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-07-31 (Mon, 31 Jul 2023)

  Changed paths:
    M Source/WebKit/Shared/WebHitTestResultData.h
    M Source/WebKit/Shared/mac/WebHitTestResultPlatformData.serialization.in
    M Source/WebKit/UIProcess/mac/WKImmediateActionController.mm
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  -----------
  Cherry-pick e3ec0669b549. rdar://problem/113156967

    Don't call PAL::getWKDDActionContextClass in macOS base system
    https://bugs.webkit.org/show_bug.cgi?id=259660
    rdar://113156967

    Reviewed by Tim Horton and Chris Dumez.

    Before 266374 at main we would only call PAL::getWKDDActionContextClass if detectedDataActionContext was non-null.
    Now we always call it when decoding a WebHitTestResultPlatformData, which causes a crash in the base system
    where the framework doesn't exist.  Use Markable to stop the crash.

    * Source/WebKit/Shared/WebHitTestResultData.h:
    * Source/WebKit/Shared/mac/WebHitTestResultPlatformData.serialization.in:
    * Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:
    (-[WKImmediateActionController _animationControllerForDataDetectedText]):
    * Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
    (WebKit::WebPage::performImmediateActionHitTestAtLocation):

    Canonical link: https://commits.webkit.org/266459@main

Identifier: 266418.1 at safari-7617.1.3-branch


  Commit: 3777fb6a311de8f6ac48318d1a19619e0dae90b1
      https://github.com/WebKit/WebKit/commit/3777fb6a311de8f6ac48318d1a19619e0dae90b1
  Author: Russell Epstein <repstein at apple.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7617.1.4

Identifier: 266039.381 at safari-7617.1.3-branch


  Commit: 0fa535799d2e45e23f76c4bcaec38aeb9b77e9d8
      https://github.com/WebKit/WebKit/commit/0fa535799d2e45e23f76c4bcaec38aeb9b77e9d8
  Author: Russell Epstein <repstein at apple.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7617.1.3.1

Identifier: 266039.382 at safari-7617.1.3-branch


  Commit: 021a156c987203bfc74ac285ce126cbde678ca28
      https://github.com/WebKit/WebKit/commit/021a156c987203bfc74ac285ce126cbde678ca28
  Author: Russell Epstein <repstein at apple.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7617.1.3.2

Canonical link: https://commits.webkit.org/266418.4@safari-7617.1.3-branch


  Commit: c1b52b58fd3598f071ac702dce3a606114dd7432
      https://github.com/WebKit/WebKit/commit/c1b52b58fd3598f071ac702dce3a606114dd7432
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M Source/WTF/wtf/dtoa/utils.h

  Log Message:
  -----------
  Cherry-pick 9bd05bda44cc. rdar://problem/113397117

    dtoa/utils.h doesn't parse after recent SDK changes
    https://bugs.webkit.org/show_bug.cgi?id=259789
    rdar://113341253

    Reviewed by Wenson Hsieh.

    * Source/WTF/wtf/dtoa/utils.h:
    Recent SDK changes resulted in CoreUtils headers getting imported into
    translation units (OutputContext.mm) that also import `dtoa/utils.h`.

    The aforementioned CoreUtils headers have long had macros Min() and Max(),
    which conflict with our template functions' definitions, and make utils.h
    fail to parse.

    As a quick workaround, undefine the rogue macros before our Min() and Max().

    Canonical link: https://commits.webkit.org/266550@main

Canonical link: https://commits.webkit.org/266418.5@safari-7617.1.3-branch


  Commit: c25e6f09c43d882654ce5305df0764e5b1d3ba64
      https://github.com/WebKit/WebKit/commit/c25e6f09c43d882654ce5305df0764e5b1d3ba64
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M Source/WTF/wtf/SHA1.h

  Log Message:
  -----------
  Cherry-pick 9809c1a27c82. rdar://problem/113397106

    SHA1.h doesn't parse after recent SDK changes
    https://bugs.webkit.org/show_bug.cgi?id=259800
    rdar://113360320

    Reviewed by Megan Gardner and Wenson Hsieh.

    * Source/WTF/wtf/SHA1.h:
    Recent SDK changes resulted in CoreUtils headers getting imported into
    translation units (MediaPlayerPrivateWebM.mm) that also import `SHA1.h`.

    The aforementioned CoreUtils headers have long had a macro SHA1(),
    which conflict with our template functions' definitions, and make SHA1.h
    fail to parse.

    As a quick workaround, undefine the rogue macros before our SHA1 class.

    Canonical link: https://commits.webkit.org/266559@main

Canonical link: https://commits.webkit.org/266418.6@safari-7617.1.3-branch


Compare: https://github.com/WebKit/WebKit/compare/a38c02a57e89%5E...c25e6f09c43d

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list