[webkit-changes] [WebKit/WebKit] 6dae8e: [WGSL] Constant size for array types should be con...

Tadeu Zagallo noreply at github.com
Tue May 14 08:45:54 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6dae8e21c19fb04f9e21abdabce268a95f543508
      https://github.com/WebKit/WebKit/commit/6dae8e21c19fb04f9e21abdabce268a95f543508
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-05-14 (Tue, 14 May 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/tests/invalid/array.wgsl

  Log Message:
  -----------
  [WGSL] Constant size for array types should be concretized
https://bugs.webkit.org/show_bug.cgi?id=274149
rdar://127986684

Reviewed by Mike Wyrzykowski.

The size of an array type has to be a concrete integer, but we were using the
constant value without concretizing, so 64-bit integers were allowed.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/array.wgsl:

Canonical link: https://commits.webkit.org/278761@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list