[webkit-changes] [WebKit/WebKit] 818907: Allow text indicator to exclude replaced elements.

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81890701a8a1726b792bbcc545d4918bf01c065e
      https://github.com/WebKit/WebKit/commit/81890701a8a1726b792bbcc545d4918bf01c065e
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    M Source/WebCore/page/FrameSnapshotting.cpp
    M Source/WebCore/page/FrameSnapshotting.h
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/TextIndicator.cpp
    M Source/WebCore/page/TextIndicator.h
    M Source/WebCore/rendering/PaintPhase.h
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm

  Log Message:
  -----------
  Allow text indicator to exclude replaced elements.
https://bugs.webkit.org/show_bug.cgi?id=274042
rdar://127251596

Reviewed by Aditya Keerthi.

Text indicator is usually about text, and so the snapshots it is
using should not include images, media, etc. Add additional flags and piping
to allow for the exclusion of replaced replaced rendered content
to allow text indicator to only be text.

* Source/WebCore/page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRectWithClip):
* Source/WebCore/page/FrameSnapshotting.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::willPaintContents):
(WebCore::LocalFrameView::paintContentsForSnapshot):
* Source/WebCore/page/TextIndicator.cpp:
(WebCore::snapshotOptionsForTextIndicatorOptions):
* Source/WebCore/page/TextIndicator.h:
* Source/WebCore/rendering/PaintPhase.h:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::calculateClipRects const):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView targetedPreviewForID:completionHandler:]):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::getTextIndicatorForID):

Canonical link: https://commits.webkit.org/278711@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications