[webkit-changes] [WebKit/WebKit] 9f0a44: [view-transitions] Names should be tree-scoped

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f0a444458dd7345fc047aaeff53e7e8aef5ec55
      https://github.com/WebKit/WebKit/commit/9f0a444458dd7345fc047aaeff53e7e8aef5ec55
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  -----------
  [view-transitions] Names should be tree-scoped
https://bugs.webkit.org/show_bug.cgi?id=273883
rdar://127995859

Reviewed by Antti Koivisto.

Corresponding spec issue: https://github.com/w3c/csswg-drafts/issues/10145
Corresponding spec PR: https://github.com/w3c/csswg-drafts/pull/10306

This ignores view-transition names from shadow DOM, given the pseudo-elements are linked to the document element,
exposing shadow DOM names to the view transition pseudo-elements would be a violation of shadow DOM principles.

We don't check for the tree scope directly in `forEachRendererInPaintOrder` because a shadow DOM element might have
flat tree descendants that have an outer tree scope.

We also use the `Styleable`'s element instead of `RenderElement`'s element because for pseudo-elements we want to consider
the associated element's tree scope.

* LayoutTests/TestExpectations:
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::captureNewState):

Canonical link: https://commits.webkit.org/278704@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications