[webkit-changes] [WebKit/WebKit] ac508f: ExtendableMessageEvent.ports should return the sam...

youennf noreply at github.com
Mon May 13 08:33:43 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac508ff120502d26793f9b60113f36baf69091db
      https://github.com/WebKit/WebKit/commit/ac508ff120502d26793f9b60113f36baf69091db
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports-worker.js
    A LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports.https-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports.https.html
    M Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp
    M Source/WebCore/workers/service/ExtendableMessageEvent.h
    M Source/WebCore/workers/service/ExtendableMessageEvent.idl

  Log Message:
  -----------
  ExtendableMessageEvent.ports should return the same object
https://bugs.webkit.org/show_bug.cgi?id=273542
rdar://127350353

Reviewed by Chris Dumez.

Reuse what was done for MessageEvent.ports in ExtendableMessageEvent.ports.
We use a JSValueInWrappedObject to store the JS ports object so that we always return the same JS object.

* LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports-worker.js: Added.
* LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports.https-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports.https.html: Added.
* Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp:
(WebCore::JSExtendableMessageEvent::ports const):
(WebCore::JSExtendableMessageEvent::visitAdditionalChildren):
* Source/WebCore/workers/service/ExtendableMessageEvent.h:
* Source/WebCore/workers/service/ExtendableMessageEvent.idl:

Originally-landed-as: bb2720bcf112. https://bugs.webkit.org/show_bug.cgi?id=273542
Canonical link: https://commits.webkit.org/278690@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list