[webkit-changes] [WebKit/WebKit] 1d59f8: [WebGPU] https://philogb.github.io/page/indraspear...

Tadeu Zagallo noreply at github.com
Mon May 13 03:43:45 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d59f80ecec0eced8582a067dcb2d25b80e25f59
      https://github.com/WebKit/WebKit/commit/1d59f80ecec0eced8582a067dcb2d25b80e25f59
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AST/ASTCompoundStatement.h
    M Source/WebGPU/WGSL/AttributeValidator.cpp
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/Parser.cpp
    M Source/WebGPU/WGSL/tests/valid/for.wgsl

  Log Message:
  -----------
  [WebGPU] https://philogb.github.io/page/indraspearls/ fails to compile shader
https://bugs.webkit.org/show_bug.cgi?id=273070
rdar://126865140

Reviewed by Mike Wyrzykowski.

Add support for attributes before compound statements.

* Source/WebGPU/WGSL/AST/ASTCompoundStatement.h:
* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::initializeVariables):
(WGSL::RewriteGlobalVariables::storeInitialValue):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseAttribute):
(WGSL::Parser<Lexer>::parseCompoundStatement):
* Source/WebGPU/WGSL/tests/valid/for.wgsl:

Canonical link: https://commits.webkit.org/278682@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list