[webkit-changes] [WebKit/WebKit] 6a9c5f: WebM file with Vorbis track plays in burst

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a9c5f885a1b3eb68c6e3d9fb5b42d84da678190
      https://github.com/WebKit/WebKit/commit/6a9c5f885a1b3eb68c6e3d9fb5b42d84da678190
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-05-12 (Sun, 12 May 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp
    M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h

  Log Message:
  -----------
  WebM file with Vorbis track plays in burst
https://bugs.webkit.org/show_bug.cgi?id=273866
rdar://124880261

Reviewed by Eric Carlson.

Add support for Block containing multiple frames. Previously we would create as many CMSampleBuffer
as found in the block, but all those samples would have the timestamp of the Block.
We now accrue the duration of each frame and properly increment the sample's timestamp accordingly.

Manually verified that file plays okay

* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::WebMParser::OnSimpleBlockBegin):
(WebCore::WebMParser::OnSimpleBlockEnd):
(WebCore::WebMParser::OnFrame):
(WebCore::WebMParser::VideoTrackData::consumeFrameData):
(WebCore::WebMParser::AudioTrackData::consumeFrameData):
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h:
(WebCore::WebMParser::TrackData::consumeFrameData):

Canonical link: https://commits.webkit.org/278665@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications