[webkit-changes] [WebKit/WebKit] d7a54e: REGRESSION (274876 at main): [ iOS Debug ] accessibil...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7a54ec9f06058d19cfa177b6bb2b92e6794dc5b
      https://github.com/WebKit/WebKit/commit/d7a54ec9f06058d19cfa177b6bb2b92e6794dc5b
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-05-11 (Sat, 11 May 2024)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AXTextMarker.h
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm

  Log Message:
  -----------
  REGRESSION (274876 at main): [ iOS Debug ] accessibility/text-marker/text-marker-range-stale-node-crash.html is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=274020
rdar://127901543

Reviewed by Darin Adler.

Introduce SafeTextMarkerData as an alternative to TextMarkerData, which uses
a WeakPtr for `node` instead of a raw pointer. TextMarkerData currently has
to keep using a raw pointer because memcpy() / memcmp() are used with this
type's bytes. However, we should use SafeTextMarkerData wherever possible
and this patch starts doing some adoption to address the crash.

* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::characterOffsetForTextMarkerData):
(WebCore::AXObjectCache::accessibilityObjectForTextMarkerData):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AXTextMarker.h:
(WebCore::SafeTextMarkerData::toTextMarkerData const):
(WebCore::TextMarkerData::toSafeTextMarkerData const):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityTextMarker initWithTextMarker:cache:]):
(-[WebAccessibilityTextMarker initWithData:cache:]):
(-[WebAccessibilityTextMarker dataRepresentation]):
(-[WebAccessibilityTextMarker visiblePosition]):
(-[WebAccessibilityTextMarker characterOffset]):
(-[WebAccessibilityTextMarker isIgnored]):
(-[WebAccessibilityTextMarker accessibilityObject]):
(-[WebAccessibilityTextMarker description]):
(-[WebAccessibilityTextMarker textMarkerData]):

Canonical link: https://commits.webkit.org/278655@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications