[webkit-changes] [WebKit/WebKit] 3ced9c: AX: AXObjectCache::postPlatformNotification should...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ced9c0227fcfedf9cb7c94b3599059b078a07dc
      https://github.com/WebKit/WebKit/commit/3ced9c0227fcfedf9cb7c94b3599059b078a07dc
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-05-11 (Sat, 11 May 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
    M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
    M Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp
    M Source/WebCore/accessibility/win/AXObjectCacheWin.cpp

  Log Message:
  -----------
  AX: AXObjectCache::postPlatformNotification should take an AccessibilityObject not an AXCoreObject.
https://bugs.webkit.org/show_bug.cgi?id=273968
<rdar://problem/127833247>

Reviewed by Darin Adler.

This tightens the type checks since we should never pass an AXIsolatedObject to notification methods. this was a leftover from the initial introduction of AXCoreObject.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::buildIsolatedTree):
(WebCore::AXObjectCache::handleAllDeferredChildrenChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):
(WebCore::AXObjectCache::handleActiveDescendantChange):
(WebCore::AXObjectCache::handleMenuListValueChanged):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::reportLoadingProgress):
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::exerciseIsIgnored):
(WebCore::AXObjectCache::postPlatformNotification):
* Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
* Source/WebCore/accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):

Canonical link: https://commits.webkit.org/278653@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications