[webkit-changes] [WebKit/WebKit] 42b0cd: Crash in transparent document markers when collect...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42b0cd59678aa755142f8bc4dddc5e5ccd91bea5
      https://github.com/WebKit/WebKit/commit/42b0cd59678aa755142f8bc4dddc5e5ccd91bea5
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-05-10 (Fri, 10 May 2024)

  Changed paths:
    M Source/WebCore/dom/DocumentMarker.h
    M Source/WebCore/dom/DocumentMarkerController.cpp
    M Source/WebCore/dom/DocumentMarkerController.h
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm

  Log Message:
  -----------
  Crash in transparent document markers when collecting.
https://bugs.webkit.org/show_bug.cgi?id=274021
rdar://127898121

Reviewed by Wenson Hsieh.

Was incorrectly casting the data for a transparent
document marker. Add the additional element data
to a transparent document maker to make it function
correctly and also not crash.

* Source/WebCore/dom/DocumentMarker.h:
* Source/WebCore/dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addTransparentContentMarker):
(WebCore::shouldInsertAsSeparateMarker):
* Source/WebCore/dom/DocumentMarkerController.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::contentContainsReplacedElement):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::updateTextIndicatorStyleVisibilityForID):

Canonical link: https://commits.webkit.org/278649@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications