[webkit-changes] [WebKit/WebKit] 1399a7: [WebGPU] Invalid command buffers need to get deall...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1399a72e4ed54005039332a4357372f9b8121ca4
      https://github.com/WebKit/WebKit/commit/1399a72e4ed54005039332a4357372f9b8121ca4
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-10 (Fri, 10 May 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/CommandBuffer.h
    M Source/WebGPU/WebGPU/CommandBuffer.mm
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/MetalSPI.h
    M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
    M Source/WebGPU/WebGPU/Queue.h
    M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  -----------
  [WebGPU] Invalid command buffers need to get dealloc'ed in a timely fashion
https://bugs.webkit.org/show_bug.cgi?id=273328
<radar://127121787>

Reviewed by Tadeu Zagallo.

Discard invalid command buffers instead of submitting
them to the driver which results in incorrect behavior
and/or uintended side effects.

Re-land with CTS test regressions fixed: bug was we would
allow an command buffer to get invalidated after it's underlying
Metal buffer was already submitted.

* Source/WebGPU/WebGPU/CommandBuffer.h:
(WebGPU::CommandBuffer::create):
* Source/WebGPU/WebGPU/CommandBuffer.mm:
(WebGPU::CommandBuffer::CommandBuffer):
(WebGPU::CommandBuffer::makeInvalid):
* Source/WebGPU/WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::create):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::Device::createCommandEncoder):
(WebGPU::CommandEncoder::CommandEncoder):
(WebGPU::CommandEncoder::makeInvalid):
(WebGPU::CommandEncoder::finish):
* Source/WebGPU/WebGPU/MetalSPI.h:
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
* Source/WebGPU/WebGPU/Queue.h:
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::ensureBlitCommandEncoder):
(WebGPU::Queue::commandBufferWithDescriptor):

Canonical link: https://commits.webkit.org/278622@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications