[webkit-changes] [WebKit/WebKit] 268766: Make setupTransitionPseudoElements end in an up-to...

Rob Buis noreply at github.com
Fri May 10 03:19:04 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 268766c7de0d0900b5c389d62be961065c6ea3dc
      https://github.com/WebKit/WebKit/commit/268766c7de0d0900b5c389d62be961065c6ea3dc
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-05-10 (Fri, 10 May 2024)

  Changed paths:
    A LayoutTests/fast/css/view-transition-pseudo-element-styles-crash-expected.txt
    A LayoutTests/fast/css/view-transition-pseudo-element-styles-crash.html
    M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  -----------
  Make setupTransitionPseudoElements end in an up-to-date render tree
https://bugs.webkit.org/show_bug.cgi?id=273962

Reviewed by Tim Nguyen.

It is important for setupTransitionPseudoElements to end in an up-to-date render tree,
after potentially invaliding the document element, since updatePseudoElementStyles expects
that for copying element properties.

* LayoutTests/fast/css/view-transition-pseudo-element-styles-crash-expected.txt: Added.
* LayoutTests/fast/css/view-transition-pseudo-element-styles-crash.html: Added.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::setupTransitionPseudoElements):

Canonical link: https://commits.webkit.org/278608@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list