[webkit-changes] [WebKit/WebKit] 4b5880: [WebXR] Split WebXROpaqueFramebuffer implementation

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b588046ceb574e6c5399952d275e4d2bcce0fd3
      https://github.com/WebKit/WebKit/commit/4b588046ceb574e6c5399952d275e4d2bcce0fd3
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2024-05-09 (Thu, 09 May 2024)

  Changed paths:
    M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
    A Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [WebXR] Split WebXROpaqueFramebuffer implementation
https://bugs.webkit.org/show_bug.cgi?id=273987
rdar://127855785

Reviewed by Mike Wyrzykowski.

Cocoa and non-Cocoa implementations of WebXROpaqueFramebuffer have diverged
greatly. Instead of using #ifdef/#endif to work around the differences, split
the implementation into Cocoa and non-Cocoa specific implementation files.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):
(WebCore::WebXROpaqueFramebuffer::blitShared):
(WebCore::WebXROpaqueFramebuffer::blitSharedToLayered):
(WebCore::WebXROpaqueFramebuffer::supportsDynamicViewportScaling const):
(WebCore::WebXROpaqueFramebuffer::drawViewport const):
(WebCore::WebXROpaqueFramebuffer::calculateViewportShared):
(WebCore::ensure): Deleted.
(WebCore::createAndBindCompositorBuffer): Deleted.
(WebCore::makeExternalImageSource): Deleted.
(WebCore::convertViewportToPhysicalCoordinates): Deleted.
(WebCore::displayLayout): Deleted.
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer): Deleted.
* Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp: Copied from Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp.
(WebCore::ensure):
(WebCore::createAndBindCompositorBuffer):
(WebCore::makeExternalImageSource):
(WebCore::WebXROpaqueFramebuffer::create):
(WebCore::WebXROpaqueFramebuffer::WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):
(WebCore::WebXROpaqueFramebuffer::usesLayeredMode const):
(WebCore::WebXROpaqueFramebuffer::resolveMSAAFramebuffer):
(WebCore::WebXROpaqueFramebuffer::blitShared):
(WebCore::WebXROpaqueFramebuffer::blitSharedToLayered):
(WebCore::WebXROpaqueFramebuffer::supportsDynamicViewportScaling const):
(WebCore::WebXROpaqueFramebuffer::displayFramebufferSize const):
(WebCore::WebXROpaqueFramebuffer::drawFramebufferSize const):
(WebCore::convertViewportToPhysicalCoordinates):
(WebCore::WebXROpaqueFramebuffer::drawViewport const):
(WebCore::displayLayout):
(WebCore::toIntSize):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
(WebCore::WebXROpaqueFramebuffer::allocateRenderbufferStorage):
(WebCore::WebXROpaqueFramebuffer::allocateAttachments):
(WebCore::WebXROpaqueFramebuffer::bindAttachments):
(WebCore::WebXROpaqueFramebuffer::calculateViewportShared):
(WebCore::WebXRExternalRenderbuffer::destroyImage):
(WebCore::WebXRExternalRenderbuffer::release):
(WebCore::WebXRExternalRenderbuffer::leakObject):
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/278600@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications