[webkit-changes] [WebKit/WebKit] 701919: Remove or disconnect some unused calls to ObjCObje...

Alex Christensen noreply at github.com
Thu May 9 08:04:01 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 701919e12d5d9b72aa051bb0976fad85ebf2e782
      https://github.com/WebKit/WebKit/commit/701919e12d5d9b72aa051bb0976fad85ebf2e782
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-05-09 (Thu, 09 May 2024)

  Changed paths:
    M Source/WebKit/Shared/API/c/mac/WKObjCTypeWrapperRef.h
    M Source/WebKit/Shared/API/c/mac/WKObjCTypeWrapperRef.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/UIProcess/ios/WKContentView.h
    M Source/WebKit/UIProcess/ios/WKContentView.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  Remove or disconnect some unused calls to ObjCObjectGraph::create
https://bugs.webkit.org/show_bug.cgi?id=273879
rdar://127743562

Reviewed by Brady Eidson.

The last use of WKConnection was removed in rdar://127167483.
This PR removes or disconnects the non-WKConnection uses of ObjCObjectGraph,
all of which are unused and have been for over a year.

_loadData SPI with userData is still used by Mail, but they only pass in an
NSData, so they don't need the full power of ObjCObjectGraph.  API::Data will do.

* Source/WebKit/Shared/API/c/mac/WKObjCTypeWrapperRef.h:
* Source/WebKit/Shared/API/c/mac/WKObjCTypeWrapperRef.mm:
(WKObjCTypeWrapperCreate): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _loadData:MIMEType:characterEncodingName:baseURL:userData:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/ios/WKContentView.h:
* Source/WebKit/UIProcess/ios/WKContentView.mm:
(-[WKContentView browsingContextController]): Deleted.
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::browsingContextController): Deleted.

Canonical link: https://commits.webkit.org/278564@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list