[webkit-changes] [WebKit/WebKit] 28c3ac: [Cleanup] RenderFlexibleBox::useChildOverridingLog...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28c3ac13fbe922206ce61d3377adbc789737018f
      https://github.com/WebKit/WebKit/commit/28c3ac13fbe922206ce61d3377adbc789737018f
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderBoxInlines.h
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.h
    M Source/WebCore/rendering/RenderReplaced.cpp

  Log Message:
  -----------
  [Cleanup] RenderFlexibleBox::useChildOverridingLogicalHeightForPercentageResolution should return the override value
https://bugs.webkit.org/show_bug.cgi?id=273880

Reviewed by Simon Fraser.

This is in preparation for making sure we don't do multiple hash lookups when using overriding logical sizes.

This patch does not change the number of lookups yet, but useChildOverridingLogicalHeightForPercentageResolution returning bool gets in the way to eliminate
all redundant hash lookups caused by the following pattern:

  if (contains())
    return value();

* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::RenderBox::availableLogicalHeightUsing const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxInlines.h:
(WebCore::RenderBox::overridingContentLogicalHeight const):
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::usedChildOverridingCrossSizeForPercentageResolution):
(WebCore::RenderFlexibleBox::usedChildOverridingMainSizeForPercentageResolution):
(WebCore::RenderFlexibleBox::usedChildOverridingLogicalHeightForPercentageResolution):
(WebCore::RenderFlexibleBox::useChildOverridingCrossSizeForPercentageResolution): Deleted.
(WebCore::RenderFlexibleBox::useChildOverridingMainSizeForPercentageResolution): Deleted.
(WebCore::RenderFlexibleBox::useChildOverridingLogicalHeightForPercentageResolution): Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):

Canonical link: https://commits.webkit.org/278547@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications