[webkit-changes] [WebKit/WebKit] 44201c: WKWebView.createWebArchiveDataWithCompletionHandle...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44201c49a1dfd788b4c5eb4393cbcae94fa84095
      https://github.com/WebKit/WebKit/commit/44201c49a1dfd788b4c5eb4393cbcae94fa84095
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm

  Log Message:
  -----------
  WKWebView.createWebArchiveDataWithCompletionHandler should actually respond with an error if there is no data
https://bugs.webkit.org/show_bug.cgi?id=273667
rdar://127469660

Reviewed by Brady Eidson.

This makes the API a little more ergonomic. I also add a call to launchInitialProcessIfNecessary
and use the main frame if no frame is specified to prevent errors when the main frame hasn't been
created yet or if the process hasn't been launched yet.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView createWebArchiveDataWithCompletionHandler:]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getWebArchiveOfFrame):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:
(TestWebKitAPI::(WebArchive, CreateCustomScheme)):

Canonical link: https://commits.webkit.org/278542@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications