[webkit-changes] [WebKit/WebKit] 6e4184: [visionOS] Some text tracks don't appear as select...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e41845ade8cf8b214283715048bfaaee9ebbf2d
      https://github.com/WebKit/WebKit/commit/6e41845ade8cf8b214283715048bfaaee9ebbf2d
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebCaptionPreferencesDelegate.cpp
    M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm

  Log Message:
  -----------
  [visionOS] Some text tracks don't appear as selected in video fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=273844
rdar://125647173

Reviewed by Simon Fraser.

When switching between "automatic" and an explicit track selection, sometimes a "change" event fails to be
fired from TextTrackList, which PlaybackSessionModelMediaElement depends upon to inform the UI process that
a change occurred. To ensure that the UI updates appropriately, call legibleMediaSelectionIndexChanged() from
PlaybackSessionManager::selectLegibleMediaOption().

Also, because communication with MediaAccessiblity now happens async in the UI process, asking for the currently
selected track immediately after making a selection returns a stale value. In the code that shims accessibility
settings, cache the value being set locally.

* Source/WebKit/WebProcess/WebCoreSupport/WebCaptionPreferencesDelegate.cpp:
(WebKit::WebCaptionPreferencesDelegate::setDisplayMode):
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionManager::selectLegibleMediaOption):

Canonical link: https://commits.webkit.org/278534@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications