[webkit-changes] [WebKit/WebKit] d004f0: [WebAuthn] Set user presence flag to false when pe...

Commit Queue noreply at github.com
Wed May 8 15:13:01 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d004f0ceeda366e05550e3de119408b4faceac26
      https://github.com/WebKit/WebKit/commit/d004f0ceeda366e05550e3de119408b4faceac26
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https-expected.txt
    M LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.h
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm
    M Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.h
    M Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm
    M Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalService.mm
    M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp

  Log Message:
  -----------
  [WebAuthn] Set user presence flag to false when performing conditional create with the platform authenticator
https://bugs.webkit.org/show_bug.cgi?id=273714
rdar://125862933

Reviewed by Brent Fulgham.

Because a test of user prescence isn't explicitly collected during the authentication ceremony
that creates a credential during a conditional create, we set the user presence flag to false
to conform with the spec.

* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::authDataFlags):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):

Canonical link: https://commits.webkit.org/278531@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list