[webkit-changes] [WebKit/WebKit] 7e0c1f: [Site Isolation] http/tests/cookies/document-cooki...

Sihui noreply at github.com
Wed May 8 13:45:36 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e0c1f7ba37a05bf1f94c48930811326619bd3df
      https://github.com/WebKit/WebKit/commit/7e0c1f7ba37a05bf1f94c48930811326619bd3df
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M LayoutTests/http/tests/cookies/document-cookie-during-iframe-parsing-expected.txt
    M LayoutTests/http/tests/cookies/document-cookie-during-iframe-parsing.html
    M LayoutTests/http/tests/cookies/resources/document-cookie-during-iframe-parsing-iframe.html
    M LayoutTests/platform/mac-site-isolation/TestExpectations

  Log Message:
  -----------
  [Site Isolation] http/tests/cookies/document-cookie-during-iframe-parsing.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=273861
rdar://127713753

Reviewed by Pascoe.

Change the test to use window.parent instead of window.top. This has no difference to the result with normal test run,
but will make test run successfully instead of timing out when it is loaded in a cross-origin iframe (e.g.
run-webkit-tests with --site-isolation option).

Also, correct the description in the test as it's not related to showModalDialog.

* LayoutTests/http/tests/cookies/document-cookie-during-iframe-parsing-expected.txt:
* LayoutTests/http/tests/cookies/document-cookie-during-iframe-parsing.html:
* LayoutTests/http/tests/cookies/resources/document-cookie-during-iframe-parsing-iframe.html:
* LayoutTests/platform/mac-site-isolation/TestExpectations:

Canonical link: https://commits.webkit.org/278524@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list