[webkit-changes] [WebKit/WebKit] 5b9a24: Ensure RemoteScrollbarsController is used by scrol...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b9a2467dd21e23e6ac66ee621f68b35611b0f6d
      https://github.com/WebKit/WebKit/commit/5b9a2467dd21e23e6ac66ee621f68b35611b0f6d
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    A LayoutTests/fast/scrolling/mac/scrollbars/scrollbars-controller-type-expected.txt
    A LayoutTests/fast/scrolling/mac/scrollbars/scrollbars-controller-type.html
    A LayoutTests/platform/mac-monterey-wk2/fast/scrolling/mac/scrollbars/scrollbars-controller-type-expected.txt
    A LayoutTests/platform/mac-ventura-wk2/fast/scrolling/mac/scrollbars/scrollbars-controller-type-expected.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/page/ChromeClient.cpp
    M Source/WebCore/page/ChromeClient.h
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/platform/ScrollableArea.h
    M Source/WebCore/platform/ScrollbarsController.h
    M Source/WebCore/platform/mac/ScrollbarsControllerMac.h
    M Source/WebCore/platform/mock/ScrollbarsControllerMock.h
    M Source/WebCore/rendering/RenderLayerCompositor.cpp
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.h

  Log Message:
  -----------
  Ensure RemoteScrollbarsController is used by scrollable areas with async scrolling
https://bugs.webkit.org/show_bug.cgi?id=272935
rdar://126719107

Reviewed by Simon Fraser.

After https://commits.webkit.org/277015@main added use of usesAsyncScrolling to determine the scrollbars
controller type, and since usesAsyncScrolling is not correct prior to layer creation, ensure creation of
a RemoteScrollbarsController after layer creation if the scrollable area does use async scrolling.

* Source/WebCore/platform/ScrollableArea.h:
(WebCore::ScrollableArea::updateScrollbarsControllerForLayerCreation):
(WebCore::ScrollableArea::hasRemoteScrollbarsController):
* Source/WebCore/platform/ScrollbarsController.h:
(WebCore::ScrollbarsController::isRemoteScrollbarsController):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingRole):
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::updateScrollbarsControllerForLayerCreation):
(WebCore::RenderLayerScrollableArea::createScrollbarsController):
* Source/WebCore/rendering/RenderLayerScrollableArea.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createScrollbarsController const):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.h:

Canonical link: https://commits.webkit.org/278517@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications