[webkit-changes] [WebKit/WebKit] 2605e0: Text invisible after a UnifiedTextReplacement sess...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2605e06756ff1850794011b2f6ec62e4ef865710
      https://github.com/WebKit/WebKit/commit/2605e06756ff1850794011b2f6ec62e4ef865710
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M Source/WebCore/dom/DocumentMarker.h
    M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h
    M Source/WebKit/WebProcess/WebPage/WebPage.h

  Log Message:
  -----------
  Text invisible after a UnifiedTextReplacement session ends.
https://bugs.webkit.org/show_bug.cgi?id=273850
rdar://127563319

Reviewed by Aditya Keerthi.

We should be getting a call to set the text visible again, but
since that isn't happening we should remove the document markers
associated with a session when it ends. This is a good thing
to do regardless, and unblocks us while waiting for a more
correct solution.

* Source/WebCore/dom/DocumentMarker.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession<WebUnifiedTextReplacementType::PlainText>):
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::updateTextIndicatorStyleVisibilityForID):

Canonical link: https://commits.webkit.org/278509@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications