[webkit-changes] [WebKit/WebKit] 1c70b1: AX: When a text input field is contained within an...

AndresGonzalezApple noreply at github.com
Wed May 8 06:37:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c70b1ecc16aa38c8042c5d01f03f3ee92f2b203
      https://github.com/WebKit/WebKit/commit/1c70b1ecc16aa38c8042c5d01f03f3ee92f2b203
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    A LayoutTests/accessibility/combobox/mac/combobox-inherited-role-expected.txt
    A LayoutTests/accessibility/combobox/mac/combobox-inherited-role.html
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp

  Log Message:
  -----------
  AX: When a text input field is contained within an element with role combobox, the input field should inherit the role combobox.
https://bugs.webkit.org/show_bug.cgi?id=273826
<rdar://problem/127671875>

Reviewed by Tyler Wilcock.

AccessibilityRenderObject::determineAccessibilityRole now accounts for the scenario where an input element is contained within element with role combobox.

* LayoutTests/accessibility/combobox/mac/combobox-inherited-role-expected.txt: Added.
* LayoutTests/accessibility/combobox/mac/combobox-inherited-role.html: Added.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
(WebCore::AccessibilityNodeObject::roleFromInputElement const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

Canonical link: https://commits.webkit.org/278506@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list