[webkit-changes] [WebKit/WebKit] 98754f: [Quirk] iPadOS: Unable to enter PIN in account lin...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 98754fdd832d03f1de253d1372d1f1963704473a
      https://github.com/WebKit/WebKit/commit/98754fdd832d03f1de253d1372d1f1963704473a
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

  Log Message:
  -----------
  [Quirk] iPadOS: Unable to enter PIN in account linking flow on shopee.sg
https://bugs.webkit.org/show_bug.cgi?id=273864
rdar://127031587

Reviewed by Tim Horton.

Add a quirk to use an *iPhone* user agent on `shopee.sg/payment/account-linking/landing`. Currently,
sending either macOS or (non-desktop-class) iPad user agents cause Shopee to load content that
doesn't work unless the user has a hardware keyboard; namely, the PIN input elements don't actually
use focusable elements at all, and instead rely on receiving hardware keyboard events.

Work around this for now with a site-specific quirk to load an iPhone user agent in this specific
landing page; while the layout doesn't fit very well for an iPad screen, it's at least functional.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsIPadMiniUserAgent):
(WebCore::Quirks::needsIPhoneUserAgent):
(WebCore::Quirks::needsIpadMiniUserAgent): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::desktopClassBrowsingRecommendedForRequest):
(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):

Canonical link: https://commits.webkit.org/278493@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications