[webkit-changes] [WebKit/WebKit] fdea88: IndexedDB.IndexedDBPersistencePrivate is flakily f...

Sihui noreply at github.com
Tue May 7 17:04:59 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fdea881caae0b8a750c4402bba6b273ea2488be1
      https://github.com/WebKit/WebKit/commit/fdea881caae0b8a750c4402bba6b273ea2488be1
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm

  Log Message:
  -----------
  IndexedDB.IndexedDBPersistencePrivate is flakily failing
https://bugs.webkit.org/show_bug.cgi?id=273842
rdar://127694474

Reviewed by Alex Christensen.

The test timed out as the first two messages ("UpgradeNeeded" and "Success") can be sent in a very short period of time.
In this case, instead of starting a second wait for the second message, the test should just check whether the second
message has arrived on the first wait. This is what getNextMessage() does: it only starts waiting when the message queue
is empty. The test should just rely on getNextMessage() to do the right thing.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
(TEST(IndexedDB, IndexedDBPersistencePrivate)):

Canonical link: https://commits.webkit.org/278483@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list