[webkit-changes] [WebKit/WebKit] 36dbfb: [Site Isolation] Do not map RemoteDictionaryPopupI...

Commit Queue noreply at github.com
Tue May 7 14:09:04 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36dbfb8093a0dd9ca003aac217e6b314dae1d696
      https://github.com/WebKit/WebKit/commit/36dbfb8093a0dd9ca003aac217e6b314dae1d696
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  [Site Isolation] Do not map RemoteDictionaryPopupInfoToRootView when site isolation disabled
https://bugs.webkit.org/show_bug.cgi?id=273836
rdar://127684586

Reviewed by Charlie Wolfe.

The RemoteDictionaryPopupInfoToRootView message expects a remote frame in the web process
it's sent to, however when site isolation is off, all frames will be local. This causes an
assertion when processing this message with site isolation off.

Whenever site isolation is off, this translation is not needed. Therefore we can avoid sending
this all together.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didPerformImmediateActionHitTest):

Canonical link: https://commits.webkit.org/278479@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list