[webkit-changes] [WebKit/WebKit] 3f3246: [Site Isolation] FrameLoader::loadURL should handl...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f3246e4670f57dff0fa6f4dfb97da6f0198573c
      https://github.com/WebKit/WebKit/commit/3f3246e4670f57dff0fa6f4dfb97da6f0198573c
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/iframe-top-level-navigation-expected.txt
    A LayoutTests/http/tests/site-isolation/iframe-top-level-navigation.html
    A LayoutTests/http/tests/site-isolation/resources/iframe-top-level-navigation-iframe.html
    M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  -----------
  [Site Isolation] FrameLoader::loadURL should handle request for existing remote frame properly
https://bugs.webkit.org/show_bug.cgi?id=273800
rdar://127631799

Reviewed by Charlie Wolfe.

FrameLoader::loadURL currently falls back to "creating a new window" flow when target frame is a remote frame -- it goes
the PolicyChecker::checkNewWindowPolicy() path. This is problematic because UI process would treat this as loading in a
new frame. To fix this, make `FrameLoader::loadURL` forward request to the remote target frame.

Test: http/tests/site-isolation/iframe-top-level-navigation.html

* LayoutTests/http/tests/site-isolation/iframe-top-level-navigation-expected.txt: Added.
* LayoutTests/http/tests/site-isolation/iframe-top-level-navigation.html: Added.
* LayoutTests/http/tests/site-isolation/resources/iframe-top-level-navigation-iframe.html: Added.
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):

Canonical link: https://commits.webkit.org/278473@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications