[webkit-changes] [WebKit/WebKit] b72f1b: [webkitscmpy] Define current user during testing

Jonathan Bedard noreply at github.com
Tue May 7 09:52:24 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b72f1b6d58ee4ecf73ff42f53dbae52ea7996ee2
      https://github.com/WebKit/WebKit/commit/b72f1b6d58ee4ecf73ff42f53dbae52ea7996ee2
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/environment.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py

  Log Message:
  -----------
  [webkitscmpy] Define current user during testing
https://bugs.webkit.org/show_bug.cgi?id=273781
rdar://127612128

Reviewed by Dewei Zhu.

BitBucket users a generic username for testing. We should allow callers of the BitBucket mock to
define a username used for mock interactions.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/environment.py:
(Environment.__init__): Add dictionary to fetch mock environment from before environment is instantiated.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
(BitBucket.__init__): Accept mock environment for the duration of the mock server.
(BitBucket.__enter__): Enter mock environment.
(BitBucket.__exit__): Exit mock environment.
(BitBucket.request): Return dynamic username.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.credentials): Pull credentials from environment.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:

Canonical link: https://commits.webkit.org/278464@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list