[webkit-changes] [WebKit/WebKit] bdfd69: repeatedly running css3/flexbox/image-percent-max-...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bdfd69d30eda08279f8f3cc1bd7e622b6af34d74
      https://github.com/WebKit/WebKit/commit/bdfd69d30eda08279f8f3cc1bd7e622b6af34d74
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/rendering/RenderFlexibleBox.cpp

  Log Message:
  -----------
  repeatedly running css3/flexbox/image-percent-max-height.html is failing
https://bugs.webkit.org/show_bug.cgi?id=267562

Reviewed by Alan Baradlay.

Currently, we check if recalculating the preferred logical width
of a flex item is needed only if the style of the flexbox itself
has changed and will cause relayout.

But flexbox relayout can be caused by other reasons e.g. when its
size is relative to its parent and the parent size has changed.

This patch moves the check from `RenderFlexibleBox::styleDidChange()`
to `RenderFlexibleBox::constructFlexItem()`.

* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::styleDidChange):
(WebCore::RenderFlexibleBox::constructFlexItem):

Canonical link: https://commits.webkit.org/278461@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications